bvaradar commented on code in PR #9778:
URL: https://github.com/apache/hudi/pull/9778#discussion_r1337464107
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/ExternalSpillableMap.java:
##########
@@ -213,6 +213,8 @@ public R put(T key, R value) {
if (this.inMemoryMap.containsKey(key)) {
this.inMemoryMap.put(key, value);
+ } else if (inDiskContainsKey(key)) {
Review Comment:
@llincc : Implementation (1) should be good. For BitCaskDiskMap, remove()
doesn't touch disk. Also, unlike get(), this scenario of evicting from disk and
landing into memory is relatively bounded. So, lets go with implementation (1)
option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
