xuzifu666 commented on code in PR #9788:
URL: https://github.com/apache/hudi/pull/9788#discussion_r1338596891
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ReflectionUtils.java:
##########
@@ -48,19 +48,17 @@ public class ReflectionUtils {
private static final Map<String, Class<?>> CLAZZ_CACHE = new HashMap<>();
public static Class<?> getClass(String clazzName) {
- if (!CLAZZ_CACHE.containsKey(clazzName)) {
- synchronized (CLAZZ_CACHE) {
- if (!CLAZZ_CACHE.containsKey(clazzName)) {
- try {
- Class<?> clazz = Class.forName(clazzName);
- CLAZZ_CACHE.put(clazzName, clazz);
- } catch (ClassNotFoundException e) {
- throw new HoodieException("Unable to load class", e);
- }
+ synchronized (CLAZZ_CACHE) {
Review Comment:
> So there is a race condition between the `containsKey` check and the `get`
call where the contains check is true but the value returned is null? Am I
understanding that correctly?
>
> If this is the case, would changing the `containsKey` to a `get` call
avoid this issue while avoiding taking a lock when possible.
@the-other-tim-brown you understand correctly，in my option this not need the
change as double if，like this pr is a better way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
