danny0405 commented on code in PR #9811:
URL: https://github.com/apache/hudi/pull/9811#discussion_r1342242418
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala:
##########
@@ -100,9 +101,13 @@ object InsertIntoHoodieTableCommand extends Logging with
ProvidesHoodieConfig wi
isOverWritePartition = true
}
}
-
- val config = buildHoodieInsertConfig(catalogTable, sparkSession,
isOverWritePartition, isOverWriteTable, partitionSpec, extraOptions)
-
+ var config = buildHoodieInsertConfig(catalogTable, sparkSession,
isOverWritePartition, isOverWriteTable, partitionSpec, extraOptions)
+ val staticOverwritePartitionPathOpt =
getStaticOverwritePartitionPath(catalogTable, partitionSpec,
isOverWritePartition)
+ staticOverwritePartitionPathOpt match {
+ case Some(staticOverwritePartitionPath) =>
+ config = config ++
Map(HoodieInternalConfig.STATIC_OVERWRITE_PARTITION_PATHS.key() ->
staticOverwritePartitionPath)
+ case _ =>
Review Comment:
Is there any way we can put the logic inside `buildHoodieInsertConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
