beyond1920 commented on PR #9809: URL: https://github.com/apache/hudi/pull/9809#issuecomment-1751669474
@linliu-code @danny0405 Sorry for late response. I was just back from vacation. The return type is true/false is enough. But something is missed in this PR. We should also check whether we should returned the records or not for those records which keys only existed in log files but does not existed in base file when read snapshot of MOR table. For example some methods in `org.apache.hudi.LogFileIterator` and `org.apache.hudi.RecordMergingFileIterator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
