danny0405 commented on code in PR #9776:
URL: https://github.com/apache/hudi/pull/9776#discussion_r1351187636
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -216,6 +233,9 @@ protected List<HoodieFileGroup>
buildFileGroups(Stream<HoodieBaseFile> baseFileS
group.addNewFileSliceAtInstant(pendingCompaction.get().getKey());
}
}
+ if (logFiles.containsKey(pair)) {
+
logFiles.get(pair).stream().sorted(HoodieLogFile.getLogFileComparator()).forEach(logFile
-> group.addLogFile(completionTimeQueryView, logFile));
+ }
Review Comment:
Yes, but the only caller already guarantees the sorting order, still think
adding a validation is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
