codope commented on code in PR #9819:
URL: https://github.com/apache/hudi/pull/9819#discussion_r1351254916
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -63,7 +64,7 @@
* @param <T> The type of engine-specific record representation, e.g.,{@code
InternalRow}
* in Spark and {@code RowData} in Flink.
*/
-public final class HoodieFileGroupReader<T> implements Closeable {
+public final class HoodieFileGroupReader<T> implements Closeable, Iterator {
Review Comment:
we should be using `ExternalSpillableMap` which can spill `HoodieRecord` to
disk if necessary. But, as you know there is a tradeoff. So, the memory
fraction is controlled by a config (max memory for spillable map in
`HoodieCommonConfig`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
