boneanxs commented on code in PR #9837:
URL: https://github.com/apache/hudi/pull/9837#discussion_r1353913717
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala:
##########
@@ -326,10 +326,18 @@ object HoodieSqlCommonUtils extends SparkAdapterSupport {
def getPartitionPathToDrop(
hoodieCatalogTable: HoodieCatalogTable,
normalizedSpecs: Seq[Map[String, String]]):
String = {
- val table = hoodieCatalogTable.table
- val allPartitionPaths = hoodieCatalogTable.getPartitionPaths
- val enableHiveStylePartitioning =
isHiveStyledPartitioning(allPartitionPaths, table)
- val enableEncodeUrl = isUrlEncodeEnabled(allPartitionPaths, table)
+ val (enableHiveStylePartitioning, enableEncodeUrl) = {
+ val tableConfig = hoodieCatalogTable.tableConfig
+ val enableHiveStylePartitioning =
Option(tableConfig.getHiveStylePartitioningEnable)
Review Comment:
There're already many codes based on `hiveStylePartitioningEnable` and
`urlEncodePartitioning` set in `hoodie.properties`, also I think upgradeHandler
already guarantee this for old tables. So it should be safe here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
