danny0405 commented on code in PR #9819:
URL: https://github.com/apache/hudi/pull/9819#discussion_r1354565693
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieReaderConfig.java:
##########
@@ -51,4 +51,11 @@ public class HoodieReaderConfig {
.sinceVersion("0.13.0")
.withDocumentation("New optimized scan for log blocks that handles all
multi-writer use-cases while appending to log files. "
+ "It also differentiates original blocks written by ingestion
writers and compacted blocks written log compaction.");
+
+ public static final ConfigProperty<Boolean> FILE_GROUP_READER_ENABLED =
ConfigProperty
+ .key("hoodie.file.group.reader.enabled")
+ .defaultValue(true)
+ .markAdvanced()
+ .sinceVersion("1.0.0")
Review Comment:
Does this option exist because we do not have enough confidence that the new
reader would cover all the read use cases? Or not sure it is robust enough? I
see the default value is true, that means user would anyway encounter these
problems, can we address them and just remove this option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
