danny0405 commented on code in PR #9819:
URL: https://github.com/apache/hudi/pull/9819#discussion_r1355983980
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -102,6 +102,18 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext,
this.start = 0;
this.length = Long.MAX_VALUE;
this.baseFileIterator = new EmptyIterator<>();
+ this.shouldUseRecordPosition = false;
Review Comment:
Oh, I see, there is no need to keep 2 constructors here, we can instantiate
the record buffer from it's factory class with the given flag
`shouldUseRecordPosition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
