xuzifu666 commented on code in PR #9863:
URL: https://github.com/apache/hudi/pull/9863#discussion_r1359203751
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -463,16 +463,6 @@ object HoodieFileIndex extends Logging {
if (listingModeOverride != null) {
properties.setProperty(DataSourceReadOptions.FILE_INDEX_LISTING_MODE_OVERRIDE.key,
listingModeOverride)
}
- val partitionColumns = metaClient.getTableConfig.getPartitionFields
Review Comment:
nice，and in our condition only merge this code would work well
https://github.com/apache/hudi/pull/9862 then we would have more test for it
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -463,16 +463,6 @@ object HoodieFileIndex extends Logging {
if (listingModeOverride != null) {
properties.setProperty(DataSourceReadOptions.FILE_INDEX_LISTING_MODE_OVERRIDE.key,
listingModeOverride)
}
- val partitionColumns = metaClient.getTableConfig.getPartitionFields
Review Comment:
nice，and in our condition only merge this code would work well
https://github.com/apache/hudi/pull/9862 then we would have more test for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
