stream2000 commented on code in PR #9118:
URL: https://github.com/apache/hudi/pull/9118#discussion_r1361435492
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/BulkInsertWriterHelper.java:
##########
@@ -69,14 +71,21 @@ public class BulkInsertWriterHelper {
@Nullable
protected final RowDataKeyGen keyGen;
+ protected final Option<FlinkStreamWriteMetrics> appendWriteMetrics;
+
public BulkInsertWriterHelper(Configuration conf, HoodieTable hoodieTable,
HoodieWriteConfig writeConfig,
String instantTime, int taskPartitionId, long
totalSubtaskNum, long taskEpochId, RowType rowType) {
- this(conf, hoodieTable, writeConfig, instantTime, taskPartitionId,
totalSubtaskNum, taskEpochId, rowType, false);
+ this(conf, hoodieTable, writeConfig, instantTime, taskPartitionId,
totalSubtaskNum, taskEpochId, rowType, false, null);
+ }
+
+ public BulkInsertWriterHelper(Configuration conf, HoodieTable hoodieTable,
HoodieWriteConfig writeConfig,
+ String instantTime, int taskPartitionId, long
taskId, long taskEpochId, RowType rowType, boolean preserveHoodieMetadata) {
+ this(conf, hoodieTable, writeConfig, instantTime, taskPartitionId, taskId,
taskEpochId, rowType, preserveHoodieMetadata, null);
}
public BulkInsertWriterHelper(Configuration conf, HoodieTable hoodieTable,
HoodieWriteConfig writeConfig,
String instantTime, int taskPartitionId, long
totalSubtaskNum, long taskEpochId, RowType rowType,
- boolean preserveHoodieMetadata) {
+ boolean preserveHoodieMetadata,
FlinkStreamWriteMetrics metrics) {
Review Comment:
Sure. PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
