stream2000 commented on code in PR #9887:
URL: https://github.com/apache/hudi/pull/9887#discussion_r1366346017
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/internal/DataSourceInternalWriterHelper.java:
##########
@@ -97,7 +97,6 @@ public void commit(List<WriteStatus> writeStatuses) {
public void abort() {
LOG.error("Commit " + instantTime + " aborted ");
- writeClient.rollback(instantTime);
Review Comment:
> So when the commit got rollback.
It's safe to remove the rollback here, since we already have eager(rollback
any failed write before commit) and lazy (clean will rollback expired failed
writes) rollback mechanism.
> Curious why the cow table does not encounter the dirty data issue. Or
maybe it exists, but no test can cover it.
Yes, this bug has nothing to do with tabletype. If we bulk insert into hudi
table using datasource v2 and fail some task, we may encounter this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
