danny0405 commented on code in PR #9879:
URL: https://github.com/apache/hudi/pull/9879#discussion_r1365496418
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java:
##########
@@ -88,7 +88,8 @@ public CompletionTimeQueryView(HoodieTableMetaClient
metaClient, String startIns
* Returns whether the instant is completed.
*/
public boolean isCompleted(String instantTime) {
- return getCompletionTime(instantTime).isPresent();
+ return this.startToCompletionInstantTimeMap.containsKey(instantTime)
+ || HoodieTimeline.compareTimestamps(instantTime, LESSER_THAN,
this.firstInstantOnActiveTimeline);
Review Comment:
This relies on the continuous instants archiving of the new timeline, our
upgrade handler needs to do a archive automically to fix the compatibility
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
