danny0405 commented on code in PR #9761:
URL: https://github.com/apache/hudi/pull/9761#discussion_r1368118968
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -866,11 +866,11 @@ public void validateInsertSchema() throws
HoodieInsertException {
}
public HoodieFileFormat getBaseFileFormat() {
- return metaClient.getTableConfig().getBaseFileFormat();
- }
-
- public HoodieFileFormat getLogFileFormat() {
- return metaClient.getTableConfig().getLogFileFormat();
+ HoodieTableConfig tableConfig = metaClient.getTableConfig();
+ if (tableConfig.contains(HoodieTableConfig.BASE_FILE_FORMAT)) {
+ return metaClient.getTableConfig().getBaseFileFormat();
+ }
+ return config.getBaseFileFormat();
Review Comment:
write config should always have higher priority, compatibility does not make
sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
