yihua commented on code in PR #9768:
URL: https://github.com/apache/hudi/pull/9768#discussion_r1369690946
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -3545,6 +3546,7 @@ private List<Path> getAllFiles(HoodieTableMetadata
metadata) throws Exception {
return allfiles;
}
+ // TODO
Review Comment:
nit: should be removed?
##########
pom.xml:
##########
@@ -115,7 +115,7 @@
<log4j2.version>2.17.2</log4j2.version>
<slf4j.version>1.7.36</slf4j.version>
<joda.version>2.9.9</joda.version>
- <hadoop.version>2.10.1</hadoop.version>
+ <hadoop.version>2.10.2</hadoop.version>
Review Comment:
Avoid version upgrade in this PR?
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieMergeOnReadSnapshotReader.java:
##########
@@ -137,7 +137,8 @@ public HoodieMergeOnReadSnapshotReader(String tableBasePath,
}
}
}
- LOG.debug("Time taken to merge base file and log file records: {}",
timer.endTimer());
+ long executionTime = timer.endTimer();
+ LOG.debug("Time taken to merge base file and log file records: {}",
executionTime);
Review Comment:
nit: no need to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
