yihua commented on code in PR #9912:
URL: https://github.com/apache/hudi/pull/9912#discussion_r1370661580
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/InstantRange.java:
##########
@@ -57,6 +59,15 @@ public String getEndInstant() {
public abstract boolean isInRange(String instant);
+ @Override
+ public String toString() {
+ return "InstantRange{"
Review Comment:
Use `this.getClass().getName()` here instead of adding `rangeType`? That
should be enough to differentiate different range types.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/InstantRange.java:
##########
@@ -34,10 +34,12 @@ public abstract class InstantRange implements Serializable {
protected final String startInstant;
protected final String endInstant;
+ protected final String rangeType;
- public InstantRange(String startInstant, String endInstant) {
+ public InstantRange(String startInstant, String endInstant, String
rangeType) {
this.startInstant = startInstant;
this.endInstant = endInstant;
+ this.rangeType = rangeType;
Review Comment:
The `rangeType` is only used by `toString()`. Should the class name be used
instead of adding `rangeType` in the constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
