yihua commented on code in PR #9887:
URL: https://github.com/apache/hudi/pull/9887#discussion_r1370778292
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/internal/DataSourceInternalWriterHelper.java:
##########
@@ -97,7 +97,6 @@ public void commit(List<WriteStatus> writeStatuses) {
public void abort() {
LOG.error("Commit " + instantTime + " aborted ");
- writeClient.rollback(instantTime);
Review Comment:
The fix makes sense based on the information created. @stream2000 could you
add a test to verify that after bulk insert with DS v2 fails, the commit is
left inflight, and a subsequent new writer / transaction rolls back the commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
