yihua commented on code in PR #9892:
URL: https://github.com/apache/hudi/pull/9892#discussion_r1371301547
##########
hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java:
##########
@@ -45,12 +45,12 @@ public class DefaultHoodieRecordPayload extends
OverwriteWithLatestAvroPayload {
public static final String DELETE_MARKER = "hoodie.payload.delete.marker";
private Option<Object> eventTime = Option.empty();
- public DefaultHoodieRecordPayload(GenericRecord record, Comparable
orderingVal) {
- super(record, orderingVal);
+ public DefaultHoodieRecordPayload(GenericRecord record, Comparable
orderingVal, Properties props) {
+ super(record, orderingVal, props);
}
Review Comment:
Yeah, this should be cleaned up separately. Regardless, the payload-related
configs should always be included so there's no correctness issue. And we're
not storing any props with the record so record processing is consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
