yihua commented on code in PR #9883:
URL: https://github.com/apache/hudi/pull/9883#discussion_r1372700756
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieKeyBasedFileGroupRecordBuffer.java:
##########
@@ -127,10 +124,12 @@ public boolean hasNext() throws IOException {
String recordKey = readerContext.getRecordKey(baseRecord,
baseFileSchema);
Pair<Option<T>, Map<String, Object>> logRecordInfo =
records.remove(recordKey);
+ Map<String, Object> metadata = readerContext.generateMetadataForRecord(
+ baseRecord, baseFileSchema, false);
Review Comment:
We'll do benchmarking on this. Likely it's ok given we're not doing much
work inside the method and the existing also extract some metadata for each
record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
