danny0405 commented on code in PR #9921:
URL: https://github.com/apache/hudi/pull/9921#discussion_r1373997166
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDSimpleBucketBulkInsertPartitioner.java:
##########
@@ -93,7 +96,9 @@ Map<String, Map<Integer, String>>
getPartitionMapper(JavaRDD<HoodieRecord<T>> re
// Generate a file that does not exist
for (int i = 0; i < numBuckets; i++) {
if (!existsBucketID.contains(i)) {
- String fileIdPrefix = BucketIdentifier.newBucketFileIdPrefix(i);
+ String fileIdPrefix = isNonBlockingConcurrencyControl
+ ? BucketIdentifier.newBucketFileIdFixedSuffix(i)
+ : BucketIdentifier.newBucketFileIdPrefix(i);
Review Comment:
Maybe we can have a unified method like
```java
BucketIdentifier.newBucketFileIdPrefix(String bucketId, boolean fixed)
```
So that we can inline the if ... else block inside the BucketIdentifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
