danny0405 commented on code in PR #9933:
URL: https://github.com/apache/hudi/pull/9933#discussion_r1375155933
##########
hudi-common/src/main/java/org/apache/hudi/common/model/WriteConcurrencyMode.java:
##########
@@ -35,9 +35,15 @@ public enum WriteConcurrencyMode {
@EnumFieldDescription("Multiple writers can operate on the table with lazy
conflict resolution "
+ "using locks. This means that only one writer succeeds if multiple
writers write to the "
+ "same file group.")
- OPTIMISTIC_CONCURRENCY_CONTROL;
+ OPTIMISTIC_CONCURRENCY_CONTROL,
- public boolean supportsOptimisticConcurrencyControl() {
- return this == OPTIMISTIC_CONCURRENCY_CONTROL;
+ // Multiple writer can perform write ops on a MOR table with simple bucket
index, and defer conflict
+ // resolution to compaction phase
+ @EnumFieldDescription("Multiple writer can perform write ops on a MOR table
with simple bucket index, "
+ + "and defer conflict resolution to compaction phase.")
+ NON_BLOCKING_CONCURRENCY_CONTROL;
+
+ public boolean supportsConcurrencyControl() {
+ return this == OPTIMISTIC_CONCURRENCY_CONTROL || this ==
NON_BLOCKING_CONCURRENCY_CONTROL;
Review Comment:
`supportsConcurrencyControl()` -> `supportsMultiWriter()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
