danny0405 commented on code in PR #9883:
URL: https://github.com/apache/hudi/pull/9883#discussion_r1375159611
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/HoodieSparkRecordMerger.java:
##########
@@ -76,6 +77,45 @@ public Option<Pair<HoodieRecord, Schema>> merge(HoodieRecord
older, Schema oldSc
}
}
+ @Override
+ public Option<Pair<HoodieRecord, Schema>> partialMerge(HoodieRecord older,
Schema oldSchema, HoodieRecord newer, Schema newSchema, Schema readerSchema,
TypedProperties props) throws IOException {
+ ValidationUtils.checkArgument(older.getRecordType() ==
HoodieRecordType.SPARK);
+ ValidationUtils.checkArgument(newer.getRecordType() ==
HoodieRecordType.SPARK);
+
+ if (newer instanceof HoodieSparkRecord) {
+ HoodieSparkRecord newSparkRecord = (HoodieSparkRecord) newer;
+ if (newSparkRecord.isDeleted()) {
+ // Delete record
+ return Option.empty();
+ }
+ } else {
+ if (newer.getData() == null) {
+ // Delete record
+ return Option.empty();
+ }
+ }
+
+ if (older instanceof HoodieSparkRecord) {
+ HoodieSparkRecord oldSparkRecord = (HoodieSparkRecord) older;
+ if (oldSparkRecord.isDeleted()) {
+ // use natural order for delete record
+ return Option.of(Pair.of(newer, newSchema));
+ }
+ } else {
+ if (older.getData() == null) {
+ // use natural order for delete record
+ return Option.of(Pair.of(newer, newSchema));
+ }
+ }
+ if (older.getOrderingValue(oldSchema,
props).compareTo(newer.getOrderingValue(newSchema, props)) > 0) {
+ return Option.of(SparkRecordMergingUtils.mergeCompleteOrPartialRecords(
+ (HoodieSparkRecord) newer, newSchema, (HoodieSparkRecord) older,
oldSchema, readerSchema, props));
Review Comment:
We can rename the method back to `mergePartialRecords`now ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
