Mathieu1124 commented on a change in pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#discussion_r456247721



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieParquetWriter.java
##########
@@ -40,7 +39,7 @@
  * HoodieParquetWriter extends the ParquetWriter to help limit the size of 
underlying file. Provides a way to check if
  * the current file can take more records with the <code>canWrite()</code>
  */
-public class HoodieParquetWriter<T extends HoodieRecordPayload, R extends 
IndexedRecord>
+public class HoodieParquetWriter<R extends IndexedRecord>

Review comment:
       > Why do we need to change this class?
   
   The Generic "T" is useless in this class, and it causes some generic 
problems in the abstraction, so I removed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to