hehuiyuan commented on code in PR #9936:
URL: https://github.com/apache/hudi/pull/9936#discussion_r1375672827
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bulk/RowDataKeyGen.java:
##########
@@ -99,7 +99,7 @@ protected RowDataKeyGen(
this.recordKeyProjection = null;
} else {
this.recordKeyFields = recordKeys.get().split(",");
- if (this.recordKeyFields.length == 1) {
+ if (this.recordKeyFields.length == 1 && this.partitionPathFields.length
== 1) {
Review Comment:
@danny0405 , which is more reasonable :
we can use SimpleAvroKeyGenerator and make it compatible with one
primary key field and multiple partition fields?
or
continue to use ComplexAvroKeyGenerator make ComplexAvroKeyGenerator
compatible with single primary key field and multiple partition fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
