rmahindra123 commented on code in PR #9955:
URL: https://github.com/apache/hudi/pull/9955#discussion_r1376970845
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroKafkaSource.java:
##########
@@ -103,14 +103,14 @@ JavaRDD<GenericRecord> toRDD(OffsetRange[] offsetRanges) {
//Don't want kafka offsets here so we use originalSchemaProvider
AvroConvertor convertor = new
AvroConvertor(originalSchemaProvider.getSourceSchema());
kafkaRDD = KafkaUtils.<String, byte[]>createRDD(sparkContext,
offsetGen.getKafkaParams(), offsetRanges,
- LocationStrategies.PreferConsistent()).map(obj ->
+ LocationStrategies.PreferConsistent()).filter(obj -> obj.value() !=
null).map(obj ->
Review Comment:
is this filter redundant, given its getting filtering in 113?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
