xuzifu666 commented on code in PR #9960:
URL: https://github.com/apache/hudi/pull/9960#discussion_r1378314872
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(),
pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
emm，in some extreme case sub-dir contains dir，cause not delete completely.
then change it to true，all files can be delete rightly @danny0405
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(),
pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
emm，in some extreme case sub-dir contains dir，cause not delete completely.
then change it to true，all files can be delete rightly @danny0405
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -699,7 +699,7 @@ public static boolean deleteDir(
pairOfSubPathAndConf -> deleteSubPath(
pairOfSubPathAndConf.getKey(),
pairOfSubPathAndConf.getValue(), true)
);
- boolean result = fs.delete(dirPath, false);
+ boolean result = fs.delete(dirPath, true);
Review Comment:
in some extreme case sub-dir contains dir，cause not delete completely. then
change it to true，all files can be delete rightly @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
