codope commented on code in PR #9872:
URL: https://github.com/apache/hudi/pull/9872#discussion_r1379930246


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -498,6 +524,40 @@ private Pair<Integer, HoodieData<HoodieRecord>> 
initializeBloomFiltersPartition(
     return Pair.of(fileGroupCount, records);
   }
 
+  protected abstract HoodieData<HoodieRecord> 
getFunctionalIndexRecords(List<Pair<String, FileSlice>> partitionFileSlicePairs,
+                                                                        
HoodieFunctionalIndexDefinition indexDefinition,
+                                                                        
HoodieTableMetaClient metaClient,
+                                                                        int 
parallelism, Schema readerSchema,
+                                                                        
SerializableConfiguration hadoopConf);
+
+  private Pair<Integer, HoodieData<HoodieRecord>> 
initializeFunctionalIndexPartition() throws Exception {
+    HoodieMetadataFileSystemView fsView = new 
HoodieMetadataFileSystemView(dataMetaClient, 
dataMetaClient.getActiveTimeline(), metadata);
+    HoodieFunctionalIndexDefinition indexDefinition = 
getFunctionalIndexDefinition("");

Review Comment:
   this is fixed. it's an old left over code which has been refactored now 
based on `HoodieFunctionalIndexDefinition`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to