This is an automated email from the ASF dual-hosted git repository.
codope pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new e4c217412fb [MINOR] Re-enable a test that got fixed (#9978)
e4c217412fb is described below
commit e4c217412fb10898ab300daabc255c72a89a903c
Author: Sagar Sumit <[email protected]>
AuthorDate: Fri Nov 3 15:35:09 2023 +0530
[MINOR] Re-enable a test that got fixed (#9978)
---
.../hudi/common/table/timeline/TestWaitBasedTimeGenerator.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
a/hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestWaitBasedTimeGenerator.java
b/hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestWaitBasedTimeGenerator.java
index 26047c57380..f8c8c47b79e 100644
---
a/hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestWaitBasedTimeGenerator.java
+++
b/hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestWaitBasedTimeGenerator.java
@@ -26,7 +26,6 @@ import org.apache.hudi.exception.HoodieLockException;
import org.apache.hadoop.conf.Configuration;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
@@ -63,11 +62,11 @@ public class TestWaitBasedTimeGenerator {
throw new HoodieLockException(e);
}
}
- boolean locked = super.tryLock(time, unit);
- if (locked) {
+ boolean isLocked = super.tryLock(time, unit);
+ if (isLocked) {
SIGNAL.countDown();
}
- return locked;
+ return isLocked;
}
}
@@ -105,7 +104,6 @@ public class TestWaitBasedTimeGenerator {
* 3> whereas t1's timestamp > t2's timestamp
* So no matter which thread firstly acquires lock, the first acquired
thread's timestamp should be earlier.
*/
- @Disabled("This test is flaky, disable it for now. Fix in review ->
https://github.com/apache/hudi/pull/9972")
@ParameterizedTest
@ValueSource(booleans = {true, false})
public void testSlowerThreadLaterAcquiredLock(boolean
slowerThreadAcquiredLockLater) throws InterruptedException {