danny0405 commented on code in PR #9871:
URL: https://github.com/apache/hudi/pull/9871#discussion_r1382533555
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -228,9 +228,10 @@ public HoodieDefaultTimeline
findInstantsInRangeByCompletionTime(String startTs,
@Override
public HoodieDefaultTimeline
findInstantsModifiedAfterByCompletionTime(String instantTime) {
return new HoodieDefaultTimeline(instants.stream()
- .filter(s -> s.getCompletionTime() != null
- && HoodieTimeline.compareTimestamps(s.getCompletionTime(),
GREATER_THAN, instantTime)
- && !s.getTimestamp().equals(instantTime)), details);
+ // either pending or completionTime greater than instantTime
+ .filter(s -> (s.getCompletionTime() == null &&
compareTimestamps(s.getTimestamp(), GREATER_THAN, instantTime))
+ || (compareTimestamps(s.getCompletionTime(), GREATER_THAN,
instantTime) && !s.getTimestamp().equals(instantTime))),
Review Comment:
The `s.getCompletionTime() != null` check is missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
