xushiyan commented on a change in pull request #1849:
URL: https://github.com/apache/hudi/pull/1849#discussion_r457130487
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -274,6 +275,7 @@ public HoodieIndexConfig build() {
DEFAULT_GLOBAL_SIMPLE_INDEX_PARALLELISM);
setDefaultOnCondition(props,
!props.containsKey(SIMPLE_INDEX_UPDATE_PARTITION_PATH),
SIMPLE_INDEX_UPDATE_PARTITION_PATH,
DEFAULT_SIMPLE_INDEX_UPDATE_PARTITION_PATH);
+ setDefaultOnCondition(props, !isHBaseIndexConfigSet,
HoodieHBaseIndexConfig.newBuilder().fromProperties(props).build());
Review comment:
@yanghua Maybe this can be done specially as below for HBase index. But
I'm inclined to leaving it as a simple rule: any sub-config should be
initialized regardless. Would like to have some input on this.
```suggestion
setDefaultOnCondition(props, indexType==IndexType.HBASE &&
!isHBaseIndexConfigSet,
HoodieHBaseIndexConfig.newBuilder().fromProperties(props).build());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
