yihua commented on code in PR #10061:
URL: https://github.com/apache/hudi/pull/10061#discussion_r1390017284
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java:
##########
@@ -128,10 +130,16 @@ public static class Config {
HoodieIncrSourceConfig.HOODIE_DROP_ALL_META_FIELDS_FROM_SOURCE.defaultValue();
}
+ private final Map<String, String> readOpts = new HashMap<>();
+
public HoodieIncrSource(TypedProperties props, JavaSparkContext
sparkContext, SparkSession sparkSession,
SchemaProvider schemaProvider) {
super(props, sparkContext, sparkSession, schemaProvider);
+ for (Object key : props.keySet()) {
+ readOpts.put(key.toString(), props.getString(key.toString()));
Review Comment:
Instead of putting every properties here, only extract
"FILE_GROUP_READER_ENABLED" and "USE_NEW_HUDI_PARQUET_FILE_FORMAT" here?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestHoodieIncrSource.java:
##########
@@ -213,10 +215,9 @@ public void
testHoodieIncrSourceInflightCommitBeforeCompletedCommit(HoodieTableT
}
}
- @ParameterizedTest
- @EnumSource(HoodieTableType.class)
- public void testHoodieIncrSourceWithPendingTableServices(HoodieTableType
tableType) throws IOException {
- this.tableType = tableType;
+ @Test
+ public void testHoodieIncrSourceWithPendingTableServices() throws
IOException {
+ this.tableType = MERGE_ON_READ;
Review Comment:
No need to change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
