danny0405 commented on code in PR #10053:
URL: https://github.com/apache/hudi/pull/10053#discussion_r1390137807


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergedReadHandle.java:
##########
@@ -99,7 +99,7 @@ private Option<FileSlice> getLatestFileSlice() {
         && 
hoodieTable.getMetaClient().getCommitsTimeline().filterCompletedInstants().lastInstant().isPresent())
 {
       return Option.fromJavaOptional(hoodieTable
           .getHoodieView()
-          
.getLatestMergedFileSlicesBeforeOrOn(partitionPathFileIDPair.getLeft(), 
instantTime)
+          .getLatestFileSlices(partitionPathFileIDPair.getLeft())

Review Comment:
   It won't, the method intends to return the latest commit but it invokes the 
`getLatestMergedFileSlicesBeforeOrOn` which has some problems on NB-CC 
scenarios.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to