Mathieu1124 commented on a change in pull request #1842:
URL: https://github.com/apache/hudi/pull/1842#discussion_r458060234
##########
File path:
hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -632,6 +632,21 @@ public FileSystemViewStorageConfig
getClientSpecifiedViewStorageConfig() {
return clientSpecifiedViewStorageConfig;
}
+ /**
+ * Commit call back configs.
+ */
+ public boolean writeCommitCallbackOn() {
+ return
Boolean.parseBoolean(props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_ON));
+ }
+
+ public String getCallbackType() {
Review comment:
> IMO, this property is not necessary. We can only depend on
`getCallbackClass ` to specify the detailed implementation. This is a simple
**SPI** mode. Otherwise, it causes two entry points in the factory you
implemented. WDYT?
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
