danny0405 commented on code in PR #10101:
URL: https://github.com/apache/hudi/pull/10101#discussion_r1395270648
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/HoodieTimelineArchiver.java:
##########
@@ -117,6 +122,10 @@ public boolean archiveIfRequired(HoodieEngineContext
context, boolean acquireLoc
} else {
LOG.info("No Instants to archive");
}
+ if (success && timerContext != null) {
+ long durationMs = metrics.getDurationInMs(timerContext.stop());
Review Comment:
Can we move the metrics handling to the write client or the service client,
the cleaning and rollback alreay follow this pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
