danny0405 commented on code in PR #10090:
URL: https://github.com/apache/hudi/pull/10090#discussion_r1395276883
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/Pipelines.java:
##########
@@ -410,10 +410,11 @@ public static DataStream<Object>
hoodieStreamWrite(Configuration conf, DataStrea
* @return the compaction pipeline
*/
public static DataStreamSink<CompactionCommitEvent> compact(Configuration
conf, DataStream<Object> dataStream) {
- return dataStream.transform("compact_plan_generate",
+ DataStreamSink<CompactionCommitEvent> compactionCommitEventDataStream =
dataStream.transform("compact_plan_generate",
TypeInformation.of(CompactionPlanEvent.class),
new CompactionPlanOperator(conf))
.setParallelism(1) // plan generate must be singleton
+ .setMaxParallelism(1)
Review Comment:
Is this line compatible with flink release before 1.18?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java:
##########
@@ -207,6 +207,7 @@ public DataStream<RowData>
produceDataStream(StreamExecutionEnvironment execEnv)
SingleOutputStreamOperator<RowData> source =
execEnv.addSource(monitoringFunction, getSourceOperatorName("split_monitor"))
.uid(Pipelines.opUID("split_monitor", conf))
.setParallelism(1)
+ .setMaxParallelism(1)
Review Comment:
Is this line compatible with flink release before 1.18?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
