codope commented on code in PR #10069:
URL: https://github.com/apache/hudi/pull/10069#discussion_r1395591267
##########
hudi-common/src/main/java/org/apache/hudi/common/table/TableSchemaResolver.java:
##########
@@ -270,10 +280,11 @@ private MessageType getTableParquetSchemaFromDataFile() {
if (instantAndCommitMetadata.isPresent()) {
HoodieCommitMetadata commitMetadata =
instantAndCommitMetadata.get().getRight();
Iterator<String> filePaths =
commitMetadata.getFileIdAndFullPaths(metaClient.getBasePathV2()).values().iterator();
- return fetchSchemaFromFiles(filePaths);
+ return Option.of(fetchSchemaFromFiles(filePaths));
} else {
- throw new IllegalArgumentException("Could not find any data file
written for commit, "
+ LOG.warn("Could not find any data file written for commit, "
Review Comment:
Why not throw exception? Does this behavior change impact functionality? I
think the job would fail previously right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
