the-other-tim-brown commented on code in PR #10067:
URL: https://github.com/apache/hudi/pull/10067#discussion_r1395704512
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -999,14 +1007,19 @@ public void runMetaSync() {
Map<String, HoodieException> failedMetaSyncs = new HashMap<>();
for (String impl : syncClientToolClasses) {
Timer.Context syncContext = metrics.getMetaSyncTimerContext();
+ boolean success = false;
try {
SyncUtilHelpers.runHoodieMetaSync(impl.trim(), metaProps, conf, fs,
cfg.targetBasePath, cfg.baseFileFormat);
+ success = true;
} catch (HoodieMetaSyncException e) {
- LOG.warn("SyncTool class " + impl.trim() + " failed with exception",
e);
+ LOG.error("SyncTool class " + impl.trim() + " failed with
exception", e);
Review Comment:
I think error is better. When I look through the logs for things not
working, I assume they are logged at the error level. Later we will fail the
pipeline too. It's just that we try to run the other meta syncs first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
