hehuiyuan commented on code in PR #10119:
URL: https://github.com/apache/hudi/pull/10119#discussion_r1395978844


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/append/AppendWriteFunction.java:
##########
@@ -112,7 +112,7 @@ protected void sendBootstrapEvent() {
     int attemptId = getRuntimeContext().getAttemptNumber();
     if (attemptId > 0) {
       // either a partial or global failover, reuses the current inflight 
instant
-      if (this.currentInstant != null) {
+      if (this.currentInstant != null && 
!metaClient.getActiveTimeline().filterCompletedInstants().containsInstant(currentInstant))
 {

Review Comment:
   It is possible.   
   writeClient.commit  is successful,  but the  log `"Commit instant [{}] 
success!` doesn't exist. Something happened when  
this.ckpMetadata.commitInstant(instant).
   
   After flink job restart, the  WriteFunction's instant is `20231114121907373`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to