xushiyan commented on code in PR #10079:
URL: https://github.com/apache/hudi/pull/10079#discussion_r1396241215
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala:
##########
@@ -76,7 +76,8 @@ private[sql] object SchemaConverters {
case DOUBLE => SchemaType(DoubleType, nullable = false)
case FLOAT => SchemaType(FloatType, nullable = false)
case LONG => avroSchema.getLogicalType match {
- case _: TimestampMillis | _: TimestampMicros =>
SchemaType(TimestampType, nullable = false)
+ case _: TimestampMillis | _: TimestampMicros | _: LocalTimestampMillis
| _: LocalTimestampMicros
+ => SchemaType(TimestampType, nullable = false)
Review Comment:
make sure to extend an existing UT to cover this? or start a new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
