yihua commented on code in PR #10125:
URL: https://github.com/apache/hudi/pull/10125#discussion_r1396550878
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##########
@@ -83,7 +83,6 @@ public class BigQuerySyncConfig extends HoodieSyncConfig
implements Serializable
.key("hoodie.gcp.bigquery.sync.use_bq_manifest_file")
.defaultValue(false)
.markAdvanced()
- .sinceVersion("0.14.0")
Review Comment:
nit: this is still needed.
##########
hudi-gcp/pom.xml:
##########
@@ -70,7 +70,6 @@ See
https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsub</artifactId>
- <version>${google.cloud.pubsub.version}</version>
Review Comment:
Is this safe to remove now?
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncTool.java:
##########
@@ -79,7 +78,7 @@ public BigQuerySyncTool(Properties props) {
this.bqSchemaResolver = BigQuerySchemaResolver.getInstance();
}
- @VisibleForTesting // allows us to pass in mocks for the writer and client
+ // allows us to pass in mocks for the writer and client
Review Comment:
Is the annotation still needed?
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##########
@@ -122,6 +121,16 @@ public class BigQuerySyncConfig extends HoodieSyncConfig
implements Serializable
.markAdvanced()
.withDocumentation("Fetch file listing from Hudi's metadata");
+ public static final ConfigProperty<Boolean>
BIGQUERY_SYNC_REQUIRE_PARTITION_FILTER = ConfigProperty
+ .key("hoodie.gcp.bigquery.sync.require_partition_filter")
+ .defaultValue(false)
+ .withDocumentation("If true, configure table to require a partition
filter to be specified when querying the table");
+
+ public static final ConfigProperty<String>
BIGQUERY_SYNC_BIG_LAKE_CONNECTION_ID = ConfigProperty
+ .key("hoodie.onehouse.gcp.bigquery.sync.big_lake_connection_id")
+ .noDefaultValue()
+ .withDocumentation("The Big Lake connection ID to use");
+
Review Comment:
Add `.sinceVersion("0.14.0")` and mark them advanced (`.markAdvanced()`, if
they are not required to be set by the users)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
