the-other-tim-brown commented on code in PR #10122:
URL: https://github.com/apache/hudi/pull/10122#discussion_r1398209508
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnReadWithCompact.java:
##########
@@ -159,6 +159,8 @@ public void
testNonBlockingConcurrencyControlWithPartialUpdatePayload() throws E
// because the data files belongs 3rd commit is not included in the last
compaction.
Map<String, String> readOptimizedResult = Collections.singletonMap("par1",
"[id1,par1,id1,Danny,23,2,par1]");
TestData.checkWrittenData(tempFile, readOptimizedResult, 1);
+ pipeline1.end();
+ pipeline2.end();
Review Comment:
If you don't close the write clients, the embedded timeline servers will not
shutdown. There were some test failures since these tests turn on reuse
timeline server by default already but were expecting new servers to come up
per run. I can roll back these changes if you want but hopefully we can find a
way to close the closeables in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
