danny0405 commented on code in PR #10122:
URL: https://github.com/apache/hudi/pull/10122#discussion_r1399959143
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteMergeOnReadWithCompact.java:
##########
@@ -159,6 +159,8 @@ public void
testNonBlockingConcurrencyControlWithPartialUpdatePayload() throws E
// because the data files belongs 3rd commit is not included in the last
compaction.
Map<String, String> readOptimizedResult = Collections.singletonMap("par1",
"[id1,par1,id1,Danny,23,2,par1]");
TestData.checkWrittenData(tempFile, readOptimizedResult, 1);
+ pipeline1.end();
+ pipeline2.end();
Review Comment:
I see why you did these changes, the
`TestWriteCopyOnWrite#testReuseEmbeddedServer` can not pass because the
embedded server started by other tests is resued, if we fix the reuse strategy
to include the `FileSystemViewStorageConfig`, the test could pass.
But overall the fix makes sense, closing the client explicitly releases the
resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
