n3nash commented on a change in pull request #1859:
URL: https://github.com/apache/hudi/pull/1859#discussion_r458490961
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java
##########
@@ -103,14 +105,19 @@ protected void init(HoodieTableMetaClient metaClient,
HoodieTimeline visibleActi
* @param visibleActiveTimeline Visible Active Timeline
*/
protected void refreshTimeline(HoodieTimeline visibleActiveTimeline) {
- this.visibleCommitsAndCompactionTimeline =
visibleActiveTimeline.getCommitsAndCompactionTimeline();
+ this.visibleCommitsAndCompactionTimeline =
visibleActiveTimeline.getCommitsReplaceAndCompactionTimeline();
}
/**
* Adds the provided statuses into the file system view, and also caches it
inside this object.
*/
protected List<HoodieFileGroup> addFilesToView(FileStatus[] statuses) {
HoodieTimer timer = new HoodieTimer().startTimer();
+ final Map<String, Set<String>> partitionFileIdsToExclude =
getFileIdsToExclude(visibleCommitsAndCompactionTimeline);
Review comment:
Does this mean that we can never go back to querying the older file
groups once they have been replaced ? Can you still do time-travel for
insert-overwrite use-cases ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
