codope commented on code in PR #10097:
URL: https://github.com/apache/hudi/pull/10097#discussion_r1401712494
##########
pom.xml:
##########
@@ -471,6 +471,8 @@
<include>org.apache.hbase.thirdparty:hbase-shaded-netty</include>
<include>org.apache.hbase.thirdparty:hbase-shaded-protobuf</include>
<include>org.apache.htrace:htrace-core4</include>
+ <!-- afterburner module for jackson performance -->
+
<include>com.fasterxml.jackson.module:jackson-module-afterburner</include>
Review Comment:
1. Should this also be reloacted as for others dependencies in
`<relocations>` below?
2. What about other fasterxml deps?
Can you check if that all bundles have shaded `AfterburnerModule` class? For
e.g. `jar tf <bundle.jar> | grep AfterburnerModule`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
