rmahindra123 commented on code in PR #10073:
URL: https://github.com/apache/hudi/pull/10073#discussion_r1401722807
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/gcs/PubsubMessagesFetcher.java:
##########
@@ -32,28 +39,48 @@
import org.slf4j.LoggerFactory;
import java.io.IOException;
+import java.time.Instant;
+import java.util.ArrayList;
import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.stream.IntStream;
-import static com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub.create;
import static
org.apache.hudi.utilities.sources.helpers.gcs.GcsIngestionConfig.DEFAULT_MAX_INBOUND_MESSAGE_SIZE;
/**
* Fetch messages from a specified Google Cloud Pubsub subscription.
*/
public class PubsubMessagesFetcher {
+ private static final int DEFAULT_BATCH_SIZE_ACK_API = 10;
+ private static final long MAX_WAIT_TIME_TO_ACK_MESSAGES =
TimeUnit.MINUTES.toMillis(1);
+
+ private final ExecutorService threadPool = Executors.newFixedThreadPool(3);
Review Comment:
why 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
