zherenyu831 commented on a change in pull request #1851:
URL: https://github.com/apache/hudi/pull/1851#discussion_r458580838
##########
File path:
hudi-client/src/main/java/org/apache/hudi/metrics/MetricsReporterType.java
##########
@@ -22,5 +22,5 @@
* Types of the reporter. Right now we only support Graphite. We can include
JMX and CSV in the future.
*/
public enum MetricsReporterType {
- GRAPHITE, INMEMORY, JMX, DATADOG
+ GRAPHITE, INMEMORY, JMX, DATADOG, USER_DEFINED
Review comment:
Yes, no need any more
##########
File path:
hudi-client/src/main/java/org/apache/hudi/metrics/MetricsReporterFactory.java
##########
@@ -48,6 +51,10 @@ public static MetricsReporter
createReporter(HoodieWriteConfig config, MetricReg
case DATADOG:
reporter = new DatadogMetricsReporter(config, registry);
break;
+ case USER_DEFINED:
Review comment:
Ok, look good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
