zhangyue19921010 commented on code in PR #10157:
URL: https://github.com/apache/hudi/pull/10157#discussion_r1402949484
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -510,6 +511,9 @@ private void initTableIfNotExists(ObjectPath tablePath,
CatalogTable catalogTabl
}
flinkConf.setString(FlinkOptions.TABLE_NAME, tablePath.getObjectName());
+
+ StreamerUtil.checkPreCombineKey(flinkConf, ((ResolvedCatalogTable)
catalogTable).getResolvedSchema());
Review Comment:
<img width="865" alt="image"
src="https://github.com/apache/hudi/assets/69956021/cf1e72d6-07ce-4c86-b1a2-3e5a07b556f5";>
Looks like UT failed related to this change. please take a look.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -510,6 +511,9 @@ private void initTableIfNotExists(ObjectPath tablePath,
CatalogTable catalogTabl
}
flinkConf.setString(FlinkOptions.TABLE_NAME, tablePath.getObjectName());
+
+ StreamerUtil.checkPreCombineKey(flinkConf, ((ResolvedCatalogTable)
catalogTable).getResolvedSchema());
Review Comment:
Also it is better to modify/create related UTs to check percombine field in
hoodie.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
