danny0405 commented on code in PR #10002:
URL: https://github.com/apache/hudi/pull/10002#discussion_r1402970319
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -598,35 +603,49 @@ private FileSlice filterUncommittedLogs(FileSlice
fileSlice) {
}
protected HoodieFileGroup addBootstrapBaseFileIfPresent(HoodieFileGroup
fileGroup) {
+ return addBootstrapBaseFileIfPresent(fileGroup,
this::getBootstrapBaseFile);
+ }
+
+ protected HoodieFileGroup addBootstrapBaseFileIfPresent(HoodieFileGroup
fileGroup, Function<HoodieFileGroupId, Option<BootstrapBaseFileMapping>>
bootstrapBaseFileMappingFunc) {
boolean hasBootstrapBaseFile = fileGroup.getAllFileSlices()
.anyMatch(fs ->
fs.getBaseInstantTime().equals(METADATA_BOOTSTRAP_INSTANT_TS));
if (hasBootstrapBaseFile) {
HoodieFileGroup newFileGroup = new HoodieFileGroup(fileGroup);
newFileGroup.getAllFileSlices().filter(fs ->
fs.getBaseInstantTime().equals(METADATA_BOOTSTRAP_INSTANT_TS))
.forEach(fs -> fs.setBaseFile(
- addBootstrapBaseFileIfPresent(fs.getFileGroupId(),
fs.getBaseFile().get())));
+ addBootstrapBaseFileIfPresent(fs.getFileGroupId(),
fs.getBaseFile().get(), bootstrapBaseFileMappingFunc)));
return newFileGroup;
}
return fileGroup;
}
protected FileSlice addBootstrapBaseFileIfPresent(FileSlice fileSlice) {
+ return addBootstrapBaseFileIfPresent(fileSlice,
this::getBootstrapBaseFile);
+ }
+
+ protected FileSlice addBootstrapBaseFileIfPresent(FileSlice fileSlice,
Function<HoodieFileGroupId, Option<BootstrapBaseFileMapping>>
bootstrapBaseFileMappingFunc) {
if (fileSlice.getBaseInstantTime().equals(METADATA_BOOTSTRAP_INSTANT_TS)) {
FileSlice copy = new FileSlice(fileSlice);
copy.getBaseFile().ifPresent(dataFile -> {
Option<BootstrapBaseFileMapping> edf =
getBootstrapBaseFile(copy.getFileGroupId());
Review Comment:
Oops, this line is useless now, can you fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
