TengHuo commented on code in PR #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r1403030619
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.table.action.commit; + +import org.apache.hudi.client.WriteStatus; +import org.apache.hudi.client.common.TaskContextSupplier; +import org.apache.hudi.client.common.HoodieEngineContext; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordPayload; +import org.apache.hudi.common.model.HoodieWriteStat; +import org.apache.hudi.common.model.WriteOperationType; +import org.apache.hudi.common.table.timeline.HoodieActiveTimeline; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.table.timeline.HoodieInstant.State; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieCommitException; +import org.apache.hudi.exception.HoodieIOException; +import org.apache.hudi.table.HoodieTable; +import org.apache.hudi.table.WorkloadProfile; +import org.apache.hudi.table.WorkloadStat; +import org.apache.hudi.table.action.BaseActionExecutor; +import org.apache.hudi.table.action.HoodieWriteMetadata; + +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.time.Duration; +import java.time.Instant; +import java.util.Iterator; +import java.util.List; +import java.util.Map; + +public abstract class BaseCommitActionExecutor<T extends HoodieRecordPayload, I, K, O, R> + extends BaseActionExecutor<T, I, K, O, R> { + + private static final Logger LOG = LogManager.getLogger(BaseCommitActionExecutor.class); + + protected final Option<Map<String, String>> extraMetadata; + protected final WriteOperationType operationType; + protected final TaskContextSupplier taskContextSupplier; + + public BaseCommitActionExecutor(HoodieEngineContext context, HoodieWriteConfig config, + HoodieTable<T, I, K, O> table, String instantTime, WriteOperationType operationType, + Option<Map<String, String>> extraMetadata) { + super(context, config, table, instantTime); + this.operationType = operationType; + this.extraMetadata = extraMetadata; + this.taskContextSupplier = context.getTaskContextSupplier(); + } + + public abstract HoodieWriteMetadata<O> execute(I inputRecords); + + /** + * Save the workload profile in an intermediate file (here re-using commit files) This is useful when performing + * rollback for MOR tables. Only updates are recorded in the workload profile metadata since updates to log blocks + * are unknown across batches Inserts (which are new parquet files) are rolled back based on commit time. // TODO : + * Create a new WorkloadProfile metadata file instead of using HoodieCommitMetadata + */ + void saveWorkloadProfileMetadataToInflight(WorkloadProfile profile, String instantTime) + throws HoodieCommitException { + try { + HoodieCommitMetadata metadata = new HoodieCommitMetadata(); + profile.getPartitionPaths().forEach(path -> { + WorkloadStat partitionStat = profile.getWorkloadStat(path.toString()); + HoodieWriteStat insertStat = new HoodieWriteStat(); + insertStat.setNumInserts(partitionStat.getNumInserts()); + insertStat.setFileId(""); + insertStat.setPrevCommit(HoodieWriteStat.NULL_COMMIT); + metadata.addWriteStat(path, insertStat); + + partitionStat.getUpdateLocationToCount().forEach((key, value) -> { + HoodieWriteStat writeStat = new HoodieWriteStat(); + writeStat.setFileId(key); + // TODO : Write baseCommitTime is possible here ? + writeStat.setPrevCommit(value.getKey()); + writeStat.setNumUpdateWrites(value.getValue()); + metadata.addWriteStat(path, writeStat); + }); + }); + metadata.setOperationType(operationType); + + HoodieActiveTimeline activeTimeline = table.getActiveTimeline(); + String commitActionType = getCommitActionType(); + HoodieInstant requested = new HoodieInstant(State.REQUESTED, commitActionType, instantTime); + activeTimeline.transitionRequestedToInflight(requested, + Option.of(metadata.toJsonString().getBytes(StandardCharsets.UTF_8)), + config.shouldAllowMultiWriteOnSameInstant()); + } catch (IOException io) { + throw new HoodieCommitException("Failed to commit " + instantTime + " unable to save inflight metadata ", io); + } + } + + protected String getCommitActionType() { + return table.getMetaClient().getCommitActionType(); + } + + protected void commitOnAutoCommit(HoodieWriteMetadata result) { + if (config.shouldAutoCommit()) { + LOG.info("Auto commit enabled: Committing " + instantTime); + commit(extraMetadata, result); + } else { + LOG.info("Auto commit disabled for " + instantTime); + } + } + + protected abstract void commit(Option<Map<String, String>> extraMetadata, HoodieWriteMetadata<O> result); + + /** + * Finalize Write operation. + * @param instantTime Instant Time + * @param stats Hoodie Write Stat + */ + protected void finalizeWrite(String instantTime, List<HoodieWriteStat> stats, HoodieWriteMetadata result) { + try { + Instant start = Instant.now(); + table.finalizeWrite(context, instantTime, stats); + result.setFinalizeDuration(Duration.between(start, Instant.now())); + } catch (HoodieIOException ioe) { + throw new HoodieCommitException("Failed to complete commit " + instantTime + " due to finalize errors.", ioe); + } + } + + /** + * By default, return the writer schema in Write Config for storing in commit. + */ + protected String getSchemaToStoreInCommit() { + return config.getSchema(); + } + + protected boolean isWorkloadProfileNeeded() { + return true; + } + + protected abstract Iterator<List<WriteStatus>> handleInsert(String idPfx, + Iterator<HoodieRecord<T>> recordItr) throws Exception; + + protected abstract Iterator<List<WriteStatus>> handleUpdate(String partitionPath, String fileId, Review Comment: May I ask if the difference of parameter `idPfx` and `fileId` between the method `handleInsert` and `handleUpdate` is designed on some purpose? I can understand for update operation, we need to find out the previous version of base file, so use file id to locate it. But in the method `BaseSparkCommitActionExecutor.handleUpsertPartition`, both the method `handleInsert` and `handleUpdate` get the parameters from `binfo.fileIdPrefix`. It's really confused. ``` protected Iterator<List<WriteStatus>> handleUpsertPartition(String instantTime, Integer partition, Iterator recordItr, Partitioner partitioner) { SparkHoodiePartitioner upsertPartitioner = (SparkHoodiePartitioner) partitioner; BucketInfo binfo = upsertPartitioner.getBucketInfo(partition); BucketType btype = binfo.bucketType; try { if (btype.equals(BucketType.INSERT)) { return handleInsert(binfo.fileIdPrefix, recordItr); } else if (btype.equals(BucketType.UPDATE)) { return handleUpdate(binfo.partitionPath, binfo.fileIdPrefix, recordItr); } else { throw new HoodieUpsertException("Unknown bucketType " + btype + " for partition :" + partition); } } catch (Throwable t) { String msg = "Error upserting bucketType " + btype + " for partition :" + partition; LOG.error(msg, t); throw new HoodieUpsertException(msg, t); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
