zhangyue19921010 commented on code in PR #10194:
URL: https://github.com/apache/hudi/pull/10194#discussion_r1408615950
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/ExternalSpillableMap.java:
##########
@@ -272,7 +272,10 @@ public Collection<R> values() {
return inMemoryMap.values();
}
List<R> result = new ArrayList<>(inMemoryMap.values());
Review Comment:
It would be great if u can also implement the `values()` function in
`RocksDbDiskMap`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
